-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix ffwd merged #22
Fix ffwd merged #22
Conversation
…etter and works for all apps
…d remained stuck. Now pressing pause/back/next/previous stops the ffwd/begin action
Hi, all done there (merge) and also I changed a little the behaviour of ffwd and rewind companion :
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
Just one question: is await self.stop_fast_forward_rewind()
also required in the fast_forward()
and rewind()
functions, as you added them in next
, previous
, skip_forward
, and skip_backward
?
You're right I'll add to them |
Done |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, this gives a few more options.
The app specific FF / RW behaviour on Apple TV is indeed an absolut mess. Just tried a few apps, and it was different everywhere :-(
- ATV+ is mixed: it works with the new commands, old FF / RW sometimes work, sometimes not
- Plex: new FF / RW begin commands don’t work
- Red Bull TV: only new skip commands work
- Play Suisse: only works with the old FF / RW, where it’s only skipping.
- Play SRF: works with the old FF / RW (this time true forward & rewind, no skipping), plus the new FF / RW begin commands.
Quite depressing, but nothing we can do.
Yes agreed, as a result I mapped FF/RW begin commands to the physical buttons, and I added old FF/RW to the screen. Maybe the upcoming touch gestures could help in the future (I am still waiting for the admin to approve the PR) |
No description provided.