Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ffwd merged #22

Merged
merged 24 commits into from
Jul 9, 2024
Merged

Fix ffwd merged #22

merged 24 commits into from
Jul 9, 2024

Conversation

albaintor
Copy link
Contributor

No description provided.

@albaintor
Copy link
Contributor Author

Hi, all done there (merge) and also I changed a little the behaviour of ffwd and rewind companion :

  • If press ffwd companion while there is a rewind_begin => stop the rewind and launch the ffwd_begin.
  • Same for the opposite (if pressing rewind while ffwd is running, we stop ffwd first)

Copy link
Contributor

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Just one question: is await self.stop_fast_forward_rewind() also required in the fast_forward() and rewind() functions, as you added them in next, previous, skip_forward, and skip_backward?

@albaintor
Copy link
Contributor Author

You're right I'll add to them

@albaintor
Copy link
Contributor Author

Done

Copy link
Contributor

@zehnm zehnm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this gives a few more options.

The app specific FF / RW behaviour on Apple TV is indeed an absolut mess. Just tried a few apps, and it was different everywhere :-(

  • ATV+ is mixed: it works with the new commands, old FF / RW sometimes work, sometimes not
  • Plex: new FF / RW begin commands don’t work
  • Red Bull TV: only new skip commands work
  • Play Suisse: only works with the old FF / RW, where it’s only skipping.
  • Play SRF: works with the old FF / RW (this time true forward & rewind, no skipping), plus the new FF / RW begin commands.

Quite depressing, but nothing we can do.

@zehnm zehnm merged commit a266e09 into unfoldedcircle:main Jul 9, 2024
3 checks passed
@albaintor
Copy link
Contributor Author

Yes agreed, as a result I mapped FF/RW begin commands to the physical buttons, and I added old FF/RW to the screen.
FF/RW begin seem to work with most apps but not all

Maybe the upcoming touch gestures could help in the future (I am still waiting for the admin to approve the PR)

@albaintor albaintor deleted the fix_ffwd_merged branch July 9, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants