Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for #1395 #1410

Merged
merged 4 commits into from
Oct 21, 2024
Merged

fix for #1395 #1410

merged 4 commits into from
Oct 21, 2024

Conversation

CalebLuster
Copy link
Collaborator

No description provided.

Copy link

cloudflare-workers-and-pages bot commented Oct 21, 2024

Deploying design-system with  Cloudflare Pages  Cloudflare Pages

Latest commit: e086aa4
Status:⚡️  Build in progress...

View logs

@Jura
Copy link
Member

Jura commented Oct 21, 2024

@CalebLuster , this is not enough, if you are committing changes in SASS or JS files - you have to run npm run build after work is done, compile changes into minified assets and add them to the repo as well

@Jura Jura merged commit ab74ba8 into develop Oct 21, 2024
1 of 2 checks passed
@Jura Jura deleted the 1395-footer-simple-variant branch December 14, 2024 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants