Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Country header outside margins are incorrect #1394

Closed
theadamparker opened this issue Oct 7, 2024 · 4 comments
Closed

Country header outside margins are incorrect #1394

theadamparker opened this issue Oct 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@theadamparker
Copy link
Contributor

The country header component's margins are incorrect.

They should work like this:
Screenshot 2024-10-07 at 4 26 54 PM

Current state:
Screenshot 2024-10-07 at 4 22 41 PM
Screenshot 2024-10-07 at 4 21 13 PM

@theadamparker theadamparker added the bug Something isn't working label Oct 7, 2024
CalebLuster added a commit that referenced this issue Oct 15, 2024
@CalebLuster
Copy link
Collaborator

@theadamparker I think I found a possible fix but I was a little confused by the ticket. I think the ticket is saying that there isn't enough space on the margins in the screen sizes but maybe I interpreted it wrong. Either way check out my new branch and the fix I made.

@CalebLuster CalebLuster self-assigned this Oct 16, 2024
@theadamparker
Copy link
Contributor Author

General approach is correct @CalebLuster, but for small screens the outside margin should be 12px (or 0.75rem). Right now it seems to be half of that.

@CalebLuster
Copy link
Collaborator

@theadamparker made another commit for that mobile adjustment

@theadamparker
Copy link
Contributor Author

Looks good @CalebLuster

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants