-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Does stripy support numpy 2.x on PyPI (pip) ? #114
Comments
Hi @jcannon-gplates, I'm not sure about the build on Pypi - I'm guessing it's compiled with numpy 1.x I'm happy to kick off a numpy>=2 build via feedstock if you like. |
No reason I can see to stay at 1.X, this is for @brmather to give final approval, though.
L
Prof Louis Moresi.
+61 2 6125 5590 or +61 4 0333 1413
***@***.******@***.***>
***@***.***?anonymous&ep=bwmEmailSignature> Book time to meet with ***@***.***?anonymous&ep=bwmEmailSignature>
…________________________________
From: Julian Giordani ***@***.***>
Sent: Monday, 3 February 2025 4:22 PM
To: underworldcode/stripy ***@***.***>
Cc: Louis Moresi ***@***.***>; Mention ***@***.***>
Subject: Re: [underworldcode/stripy] Does stripy support numpy 2.x on PyPI (pip) ? (Issue #114)
Hi @jcannon-gplates<https://github.com/jcannon-gplates>, I'm not sure about the build on Pypi - I'm guessing it's compiled with numpy 1.x
@brmather<https://github.com/brmather> & @lmoresi<https://github.com/lmoresi> any comment?
I'm happy to kick off a numpy>2 build via feedstock if you like.
—
Reply to this email directly, view it on GitHub<#114 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ADABPI5HYAB33DFZ6WME5OD2N34JPAVCNFSM6AAAAABWJC4YEKVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDMMRZHE4TENBQG4>.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
Thanks, but conda is all good - it looks like @brmather has numpy 2 working there. The code snippet above is really just for PyPI. |
@julesghub what is your PyPI username? |
Just found it. jgiordani Has been added |
Thanks - I'll update it later today. |
Great, thanks!! I see that "test_linear_interpolation" is failing. Gosh I hope that's not a NumPy 2 issue. No hurry for us, we can always set By the way, regarding 7cfce70, it's fine to leave |
I can see that stripy 2.3.3 on conda supports numpy 2.x (conda-forge/stripy-feedstock#21).
Do you know if stripy 2.3.3 on PyPI was also compiled with numpy 2.x ?
Because in GPlates/gplately#305 we're getting a numpy import error that appears to come from stripy. But if we downgrade numpy from 2.x to 1.x it's fine.
Building against numpy 2.x supports both numpy 1.x and 2.x at runtime. So you could force compilation against numpy 2.x with something like the following in your "pyproject.toml":
...this is what I do in pygplates.
The text was updated successfully, but these errors were encountered: