[UNDERTOW-2371] initialize the DefaultServer once to speed up test HttpContinueSslServletTestCase #1574
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TestBoost Could you please create a ticket? |
baranowb
added
enhancement
TestBoost
changed the title
|
Sure, I just submit a ticket here https://issues.redhat.com/browse/UNDERTOW-2371. I don't know why the test class |
baranowb
added
the
waiting PR update
|
@TestBoost could you please force push again to trigger CI? |
ropalka
approved these changes
Aug 7, 2024
baranowb
requested changes
Oct 9, 2024
| } | ||
|
|
||
| @Before | ||
| public void before() throws Exception { | ||
| public static void before() throws Exception { |
There was a problem hiding this comment.
Is this method even used now?
…tpContinueSslServletTestCase Signed-off-by: Flavia Rainone <[email protected]>
baranowb
added
next release
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are five tests in the test class
HttpContinueSslServletTestCase. However, they reply on the same DefaultServer to send post http request. The time cost of start or stop for the DefaultServer is high. They are not modifying the contents of the DefaultServer, thus we can just initialize the DefaultServer once before or after all test methods inside test classHttpContinueSslServletTestCase.The test runtime can jump from
5.43160 sto1.8027 safter applying these changes when run on our machine.