-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mypy: fix errors, codecov UNKNOWN badge fix #171
Conversation
Add mypy (http://mypy-lang.org/) to execute static type checking in Quantus CI/CD pipeline
Codecov Report
@@ Coverage Diff @@
## main #171 +/- ##
==========================================
- Coverage 92.86% 92.74% -0.13%
==========================================
Files 54 54
Lines 2649 2660 +11
==========================================
+ Hits 2460 2467 +7
- Misses 189 193 +4
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thanks for going over all the types!
Remaining is to resolve merge conflicts as seen ^^. |
# Conflicts: # quantus/functions/explanation_func.py # quantus/helpers/asserts.py # quantus/helpers/plotting.py # quantus/metrics/axiomatic/completeness.py # quantus/metrics/axiomatic/input_invariance.py # quantus/metrics/axiomatic/non_sensitivity.py # quantus/metrics/base.py # quantus/metrics/complexity/complexity.py # quantus/metrics/complexity/effective_complexity.py # quantus/metrics/complexity/sparseness.py # quantus/metrics/faithfulness/faithfulness_correlation.py # quantus/metrics/faithfulness/faithfulness_estimate.py # quantus/metrics/faithfulness/infidelity.py # quantus/metrics/faithfulness/irof.py # quantus/metrics/faithfulness/monotonicity.py # quantus/metrics/faithfulness/monotonicity_correlation.py # quantus/metrics/faithfulness/pixel_flipping.py # quantus/metrics/faithfulness/region_perturbation.py # quantus/metrics/faithfulness/road.py # quantus/metrics/faithfulness/selectivity.py # quantus/metrics/faithfulness/sensitivity_n.py # quantus/metrics/faithfulness/sufficiency.py # quantus/metrics/localisation/attribution_localisation.py # quantus/metrics/localisation/auc.py # quantus/metrics/localisation/focus.py # quantus/metrics/localisation/pointing_game.py # quantus/metrics/localisation/relevance_mass_accuracy.py # quantus/metrics/localisation/relevance_rank_accuracy.py # quantus/metrics/localisation/top_k_intersection.py # quantus/metrics/randomisation/model_parameter_randomisation.py # quantus/metrics/randomisation/random_logit.py # quantus/metrics/robustness/avg_sensitivity.py # quantus/metrics/robustness/consistency.py # quantus/metrics/robustness/continuity.py # quantus/metrics/robustness/local_lipschitz_estimate.py # quantus/metrics/robustness/max_sensitivity.py
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, remaining fix is mypy
in CI/CD
…_fix_issues_ci_cd
Checked the remaining errors which are fixed or rejected (as non-important error or error is wrong). |
…mypy_fix_issues_ci_cd Mypy: fix errors, codecov UNKNOWN badge fix Minimum acceptance criteria achieved.
Implemented changes
Minimum acceptance criteria