-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor custom_preprocess() for more robustness #167
Conversation
Codecov Report
@@ Coverage Diff @@
## main #167 +/- ##
==========================================
- Coverage 94.62% 94.51% -0.12%
==========================================
Files 51 51
Lines 2420 2370 -50
==========================================
- Hits 2290 2240 -50
Misses 130 130
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see the comments. Some require changes on several places, like update docstrings of Returns and Params etc. Thank you!
…se this attribute.
…sed in any metric.
0923756
to
437395b
Compare
…sed in any metric. Use new and flexible custom_preprocess functionality for the metrics Consistency and Sufficiency.
437395b
to
509ca7e
Compare
Coverage seems to have only decreased because this PR has a lot of deletions, so the absolute number of hits has decreased. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, let's merge!
…feature/robust-custom-preprocessing Refactor custom_preprocess() for more robustness
Info about PR:
Instead of passing the complete tuple with
model, x_batch, y_batch, a_batch, s_batch, ..
we instead pass a dictionary with the variable names as keys.If a key matches a variable name like
x_batch
, it will be overwritten.If a key refers to a new variable, this variable will be passed instance-wise to
evaluate_instance()
.If we pass None instead of a dictionary in
custom_preprocess
, no changes or additional variables will be passed to evaluate_instance.Minimum acceptance criteria