-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[fix] Update contracts variable and function names #193
Comments
@adrianvrj Kindly assign me to work on this issue. ETA: One day |
I'm Eleazar, a fullstack Blockchain developer. |
Let me handle this issue! |
Hi @adrianvrj, can I work on this? |
holla @adrianvrj i'm a forntend developer and a blockchain dev i will:
May I be assigned to this? |
May I take care of this? |
I'd like to handle this task. |
@adrianvrj I’d like to resolve this. |
I would like to contribute further in this project! So such a task would help me familiarise myself with the project itself and its structure |
Can i please be assigned to this issue @adrianvrj |
Hi, I'm Josué Brenes and I'll be working on issue. I estimate this will take 1 day to complete. Proposed Solution for Name Formatting ChangeI would address this as follows:
|
I can quickly tackle on this issue. I will update the functions and variable names this will also affect the test cases; therefore, I will also update the tests to make sure all tests are passing as they should. |
hey @adrianvrj i'm a fullstack dev and i would love to work on this issue please kindly assign :) 1. Audit Current Naming ConventionsStart by reviewing all the function and variable names in the codebase, especially focusing on any instances where snake_case is used. 2. Refactor Names to Camel CaseUpdate each identified snake_case function and variable to camelCase, adhering to Cairo's convention. 3. Ensure No Functional ChangesThis issue is solely focused on refactoring names. Be cautious not to alter the function logic or parameters in any other way. 4. Review and TestAfter renaming, review each change thoroughly to ensure all instances are updated. Use “Find and Replace” as needed. Eta: 12hrs |
@adrianvrj can I please work on this? |
Mind if I try this one? |
Hi, I'm Derian, a fullstack developer and member of Dojo Coding, and I will be working on issue #193. I estimate it will take me 12 hours to complete. Here's how I will approach this issue: I would change all variables and functions that are in camel case to snake case, following the Cairo style standard. |
Hello, my name is Joanne. I would love to work on this issue. I have a strong background in Rust and a good understanding of Cairo, and I am familiar with the concept of snake_case. I look forward to working on these issue. |
Hello, I have a solid background in Cairo, as well as experience refactoring codebases to ensure adherence to best practices. I understand the implications of naming conventions for both readability and project standards. By systematically updating these names, I can contribute to a cleaner and more intuitive codebase that aligns with the Cairo community's norms, Josue From Dojo Coding, |
hello! @adrianvrj can I take this? should be fast |
Hello @adrianvrj, To solve this issue, I would change each variable and function name to use Camel Case (like this, functionName). I would also update imports to the changed camel case names to ensure consistent camel case naming. ETA is 5 hours. |
Please, is this still available ? |
@sotoJ24 any update on this issue? |
Hello @EmmanuelAR, is this issue still open for collaboration? Please let me know, and I’ll raise a PR by tomorrow. |
Is your feature request related to a problem? Please describe.
Currently we are using mixed snake and camel case for the functions and variables names.
Describe the solution you'd like
In cairo, camel case is normally used, please update all of the variable and functions that use camel case to use snake case
The text was updated successfully, but these errors were encountered: