This repository has been archived by the owner on Aug 17, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 5
scope.yml
config file support
#187
Open
tonyredondo
wants to merge
12
commits into
master
Choose a base branch
from
config-file
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tonyredondo
force-pushed
the
config-file
branch
2 times, most recently
from
March 14, 2020 22:28
5f19b6a
to
72dc01c
Compare
drodriguezhdez
approved these changes
Mar 16, 2020
tonyredondo
force-pushed
the
config-file
branch
4 times, most recently
from
March 18, 2020 16:42
6127aba
to
bbd5aa6
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #19
This
PR
enables the support forscope.yml
config file. This removes the old environment variables loader system for a newconfig
package to load the configurations following this priority:env -> yaml -> defaults
Uses a new library https://github.com/undefinedlabs/go-env to handle environment variables and default values.