Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot edit additional properties on files. #20

Closed
hailwood opened this issue Nov 20, 2015 · 7 comments
Closed

Cannot edit additional properties on files. #20

hailwood opened this issue Nov 20, 2015 · 7 comments

Comments

@hailwood
Copy link

E.g. We have a "SeoTitle" field that we add to Image via an extension.
We have another class "LinkedImage" which has_one Link (https://github.com/sheadawson/silverstripe-linkable).

With the standard File Manager we can edit these additional fields/relations as well. However with kickassets the form seems fixed, combining this issue with using FileAttachmentField instead of UploadField we lose any capability to edit these fields.

@unclecheese
Copy link
Owner

Yeah, there isn't a clear solution to this problem yet, unfortunately.

@jonom
Copy link
Contributor

jonom commented Mar 16, 2016

Hey @unclecheese I'm dying to use this module in production but unfortunately not being able to access the detailed edit form is a deal breaker for me. I had a quick look to see if I could do anything about this but I see what you mean, since this is all React based it doesn't look like this is something that could be fixed until SS4 is out and we have a solution for this kind of problem baked in to the framework.

I was wondering for a short-term SS3 fix if it might be worth adding a 'More options' link to the edit form that takes you through to the regular editing form at /admin/assets/EditForm/field/File/item/{$FileID}/edit?

Then we could have our cake and eat it too.

Example:

options

@chillu
Copy link

chillu commented Mar 21, 2016

FYI, this is the framework approach we'll take for SS4: silverstripe/silverstripe-framework#4938

@jonom
Copy link
Contributor

jonom commented Mar 30, 2016

Thanks @chillu, bit over my head for now 😅

@unclecheese If I develop a PR for proposal above would you be interested?

@unclecheese
Copy link
Owner

Honestly we're so close to reinventing the wheel on this one, I think it would be wasteful to build it for KickAssets. In SS4 we should have some semblance of this API, correct, @chillu ?

Once we have that, we can either build on it, or maybe even use it in its entirety. That is, if this module isn't completely deprecated by the awesomeness of the new AssetAdmin. :-)

Ideally, the form field schema stuff goes into a module that works in 3.x, so we could plug it in and offer backward compatibility.

@jonom
Copy link
Contributor

jonom commented Mar 30, 2016

Oh yeah - sorry I wasn't talking about developing that (no way!) I'm just talking about adding a 'More options' link that takes you to the regular Assets Admin interface for that file. Maybe it could be configurable whether it's enabled or not so it's not cluttering up the interface if it's not needed?

@chillu
Copy link

chillu commented Mar 30, 2016

@unclecheese Yeah SS4 will have a form field schema with a "builder" react component and a way to get a PHP form as JSON, so you should be able to use that in KickAssets. Form field support will be fairly limited for now, we're converting them on demand (and really need some time to research React/Redux form UI libs before we get too deep into that).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants