test(test): fix inconsistent timezone in date tests #40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed a few date-related tests weren't passing for me locally:
I believe this is because
setFullYear
applies the system's local time zone automatically. UsingsetMilliseconds
should avoid this issue. With this change, all tests pass locally and presumably shouldn't impact the github actions test runner.I love the library and I'm excited to start poking around the code more!