Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uppercase pre-translations #148

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Feb 8, 2024

before

>>> from slugify import PRE_TRANSLATIONS
>>> print(PRE_TRANSLATIONS)
[('Ё', 'E'), ('ё', 'e'), ('я', 'ya'), ('х', 'h'), ('у', 'y'), ('щ', 'sch'), ('ю', 'u'), ('Ä', 'Ae'), ('ä', 'ae'), ('ö', 'oe'), ('ü', 'ue'), ('Χ', 'Ch'), ('χ', 'ch'), ('Ξ', 'X'), ('ϒ', 'Y'), ('υ', 'y'), ('ύ', 'y'), ('ϋ', 'y'), ('ΰ', 'y')]

after

>>> from slugify import PRE_TRANSLATIONS
>>> print(PRE_TRANSLATIONS)
[('Ю', 'U'), ('Щ', 'Sch'), ('У', 'Y'), ('Х', 'H'), ('Я', 'Ya'), ('Ё', 'E'), ('ё', 'e'), ('я', 'ya'), ('х', 'h'), ('у', 'y'), ('щ', 'sch'), ('ю', 'u'), ('Ü', 'Ue'), ('Ö', 'Oe'), ('Ä', 'Ae'), ('ä', 'ae'), ('ö', 'oe'), ('ü', 'ue'), ('Ϋ́', 'Y'), ('Ϋ', 'Y'), ('Ύ', 'Y'), ('Υ', 'Y'), ('Χ', 'Ch'), ('χ', 'ch'), ('Ξ', 'X'), ('ϒ', 'Y'), ('υ', 'y'), ('ύ', 'y'), ('ϋ', 'y'), ('ΰ', 'y')]

@mib1185 mib1185 force-pushed the fix-pre-translations branch 2 times, most recently from 7615b39 to 83d358f Compare February 8, 2024 17:32
@un33k
Copy link
Owner

un33k commented Feb 8, 2024

@mib1185 Great catch. Please kindly point your PR to the ci branch instead.

@mib1185 mib1185 changed the base branch from master to ci February 8, 2024 18:22
@mib1185
Copy link
Contributor Author

mib1185 commented Feb 8, 2024

changed the target branch to ci

@un33k un33k merged commit a243ccd into un33k:ci Feb 8, 2024
@mib1185 mib1185 deleted the fix-pre-translations branch February 8, 2024 18:24
@mib1185
Copy link
Contributor Author

mib1185 commented Feb 8, 2024

thanks for fast reaction and merging this 👍

un33k added a commit that referenced this pull request Feb 8, 2024
* Remove compatibility with unsupported Python versions (#146)
* fix uppercase pre-translations (#148)

Co-authored-by: Viicos <[email protected]>
Co-authored-by: Michael <[email protected]>
@un33k
Copy link
Owner

un33k commented Feb 8, 2024

Merged. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants