Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enable isolate mode w/ typescript-eslint v8 #93

Merged
merged 4 commits into from
Jun 24, 2024

Conversation

SukkaW
Copy link
Collaborator

@SukkaW SukkaW commented Jun 24, 2024

typescript-eslint v8 beta has made projectService stable (EXPERIMENTAL_useProjectService is now just projectService) thus previous delete parserOptions.EXPERIMENTAL_useProjectService no longer works on typescript-eslint v8.

The PR adds delete parserOptions.useProjectService. When typescript-eslint v8 becomes stable, we might want to adapt typescript-eslint/typescript-eslint#9233 (typescript-eslint/typescript-eslint#8428)

Copy link

changeset-bot bot commented Jun 24, 2024

🦋 Changeset detected

Latest commit: a52f517

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-import-x Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codesandbox-ci bot commented Jun 24, 2024

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

@SukkaW SukkaW force-pushed the fix-es-eslint-v8-1 branch from 023c5be to feec904 Compare June 24, 2024 10:01
@JounQin
Copy link
Member

JounQin commented Jun 24, 2024

@SukkaW I don't have quite enough time working on OSS these days, do you want to help maintaining this project? If so I'd like to invite you as a maintainer.

@SukkaW
Copy link
Collaborator Author

SukkaW commented Jun 24, 2024

@SukkaW I don't have quite enough time working on OSS these days, do you want to help maintaining this project? If so I'd like to invite you as a maintainer.

Sure! And you can also invite others who are interested in this project and maintain this together.

@JounQin
Copy link
Member

JounQin commented Jun 24, 2024

Sure! And you can also invite others who are interested in this project and maintain this together.

I've invited you as administer, so you can invite others I believe.

@SukkaW SukkaW requested a review from JounQin June 24, 2024 10:42
@SukkaW SukkaW merged commit 64bf1a6 into un-ts:master Jun 24, 2024
1 of 14 checks passed
robtaylor pushed a commit to robtaylor/eslint-plugin-import-x that referenced this pull request Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants