Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ignore classifier check if either spam or ham samples not loaded #99

Merged
merged 2 commits into from
Jul 24, 2024

Conversation

umputun
Copy link
Owner

@umputun umputun commented Jul 24, 2024

In the discussion at #98, we encountered a scenario where there were no samples available, yet dynamic spam was being learned. This occurred because a binary version was executed without any spam or ham samples. Consequently, the classifier only had spam samples (without any ham samples) and tended to label many messages as spam. While this behavior is technically logical, it is surprising and unexpected for users.

This pull request addresses the issue by disabling the classifier check when either the spam samples or ham samples are empty. Although this fix is not perfect and may lead to some confusion when users add spam samples without observing any immediate changes, it is considered preferable as it is less disruptive.

Furthermore, the documentation will be updated to explain how the system operates in the absence of ham or spam samples.

umputun added 2 commits July 24, 2024 03:58
@umputun umputun merged commit eca1b1b into master Jul 24, 2024
2 of 3 checks passed
@umputun umputun deleted the ignore-classifier branch July 24, 2024 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant