ignore classifier check if either spam or ham samples not loaded #99
+35
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the discussion at #98, we encountered a scenario where there were no samples available, yet dynamic spam was being learned. This occurred because a binary version was executed without any spam or ham samples. Consequently, the classifier only had spam samples (without any ham samples) and tended to label many messages as spam. While this behavior is technically logical, it is surprising and unexpected for users.
This pull request addresses the issue by disabling the classifier check when either the spam samples or ham samples are empty. Although this fix is not perfect and may lead to some confusion when users add spam samples without observing any immediate changes, it is considered preferable as it is less disruptive.
Furthermore, the documentation will be updated to explain how the system operates in the absence of ham or spam samples.