Update code comments, improve formatting, and adjust Dockerfile #214
+33
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
paskal
commented
Jan 6, 2025
paskal
commented
- Simplify and clarify comments in approved_users.go
- Fix formatting and spacing in admin.go and detector.go
- Update Dockerfile to use Alpine 3.21 and improve readability
- Add var/ and logs/ to .dockerignore and .gitignore
- Fix typo in README.md
- Improve error handling in main.go
- Enhance test formatting in webapi_test.go
- Clean up code structure and remove unused imports
Deploying tg-spam with
|
| Latest commit: |
223fcf7
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://93217775.tg-spam.pages.dev |
| Branch Preview URL: | https://paskal-small-fixes.tg-spam.pages.dev |
paskal
force-pushed
the
paskal/small-fixes
branch
from
b048a87 to
e0975fc
Compare
paskal
commented
Jan 6, 2025
app/main.go
Outdated
| @@ -149,7 +149,7 @@ func main() { | |||
| p := flags.NewParser(&opts, flags.PrintErrors|flags.PassDoubleDash|flags.HelpFlag) | |||
| p.SubcommandsOptional = true | |||
| if _, err := p.Parse(); err != nil { | |||
| if err.(*flags.Error).Type != flags.ErrHelp { | |||
| if !errors.Is(err.(*flags.Error).Type, flags.ErrHelp) { | |||
There was a problem hiding this comment.
Now when it's extracted I see that this is actually wrong, error.Is should be comparing plain err and not err.Type.
- Simplify and clarify comments in approved_users.go - Fix formatting and spacing in admin.go and detector.go - Update Dockerfile to use Alpine 3.21 and improve readability - Add var/ and logs/ to .dockerignore and .gitignore - Fix typo in README.md - Improve error handling in main.go - Enhance test formatting in webapi_test.go - Clean up code structure and remove unused imports
Remove unnecessary type assertion when checking for help flag error, as errors.Is() can directly compare the error types.
paskal
force-pushed
the
paskal/small-fixes
branch
from
e0975fc to
223fcf7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.