Change unban mechanics #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A built-in web server proved to be a pain as it requires a non-trivial setup, like adding reverse proxy, managing firewall ports/forwarding, terminating SSL, etc. We better use the telegram callback (i.e., a button with action) instead of the link, which works directly with telegram protocol and doesn't require any exceptional support on the client side.
Important: the change is partially breaking in case the user runs with command-line parameters.
--admin.url,--admin.secret, and--admin.addressare not supported anymore, as we are not running a web server.In case parameters are set via env, it will be fine, as
ADMIN_URL,ADMIN_SECRET, andADMIN_ADDRESSwill be ignored.