Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling the "admin forwarding msg to admin channel -> ban" feature #123

Closed
DarthGandalf opened this issue Sep 12, 2024 · 2 comments · Fixed by #124
Closed

Disabling the "admin forwarding msg to admin channel -> ban" feature #123

DarthGandalf opened this issue Sep 12, 2024 · 2 comments · Fixed by #124

Comments

@DarthGandalf
Copy link
Contributor

There are reasons to forward messages to admin channel other than to tell the bot to ban the user. And if the ban is what's needed, /spam command is enough.

This feature will lead to accidental bans of innocent people.

But also it's buggy and shows errors like error: not found "" in locator when the source of the message is not in the moderated channel, but elsewhere. Also note the "" in it: if someone posts a picture in the channel, but then one of admins forwards another unrelated picture from someone else, will that first user be banned for posting a picture? Since the hash of an empty string "" is the same.

The only way I see how to disable this (other than editing source code) is to disable admin group, but the feature of admin group is still useful as the admin-visible log of whom the bot banned, to make it easy to unban them.

@DarthGandalf
Copy link
Contributor Author

Hm, from reading source, DisableAdminSpamForward may actually do what I want.

The issue is with the description of this option - it sounds that it disables the feature of the bot itself forwarding spam message TO the admin channel

@umputun
Copy link
Owner

umputun commented Sep 14, 2024

If you can improve the docs to make them clearer and more readable, please provide a PR.

@umputun umputun closed this as completed Sep 14, 2024
DarthGandalf added a commit to DarthGandalf/tg-spam that referenced this issue Sep 14, 2024
umputun pushed a commit that referenced this issue Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants