CI: build images in PRs, don't run CI on unused files #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paskal
force-pushed
the
paskal/improve_ci
branch
2 times, most recently
from
54d019b to
0b10521
Compare
paskal
force-pushed
the
paskal/improve_ci
branch
from
0b10521 to
191ba80
Compare
umputun
reviewed
Dec 29, 2024
| - name: build base.app image (no push) | ||
| if: ${{ github.ref != 'refs/heads/master' }} | ||
| run: | | ||
| docker build -t ghcr.io/umputun/baseimage/app:latest base.alpine -f base.alpine/Dockerfile |
There was a problem hiding this comment.
the tag is confusing, and someday someone will push it and break things. I suggest dropping the tag here.
| run: | | ||
| docker build -t ghcr.io/umputun/baseimage/app:latest base.alpine -f base.alpine/Dockerfile | ||
|
|
||
| - name: build and push base.app image |
There was a problem hiding this comment.
maybe change name to "build and push master base.app image"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, CI checked nothing when ran outside of master.