feat: make loadEntry and beforeLoad runs parallelly (#2749)

umijs · Oct 23, 2023 · e448082 · e448082
1 parent 317961e
commit e448082
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/.changeset/shiny-jeans-sip.md b/.changeset/shiny-jeans-sip.md
@@ -0,0 +1,5 @@
+---
+"qiankun": patch
+---
+
+feat: make loadEntry and beforeLoad runs parallelly
diff --git a/packages/qiankun/src/core/loadApp.ts b/packages/qiankun/src/core/loadApp.ts
@@ -58,6 +58,8 @@ export default async function loadApp<T extends ObjectType>(
 
   const containerOpts: LoaderOpts = { fetch, sandbox: sandboxInstance, transformer };
 
+  const lifecyclesPromise = loadEntry<MicroAppLifeCycles>(entry, microAppContainer, containerOpts);
+
   const assetPublicPath = calcPublicPath(entry);
   const {
     beforeUnmount = [],
@@ -68,9 +70,10 @@ export default async function loadApp<T extends ObjectType>(
   } = mergeWith({}, getAddOns(global, assetPublicPath), lifeCycles, (v1, v2) =>
     concat((v1 ?? []) as LifeCycleFn<T>, (v2 ?? []) as LifeCycleFn<T>),
   );
+  // FIXME Due to the asynchronous execution of loadEntry, the DOM of the sub-app is inserted synchronously through appendChild, and inline scripts are also executed synchronously. Therefore, the beforeLoad may need to rely on transformer configuration to coordinate and ensure the order of asynchronous operations.
   await execHooksChain(toArray(beforeLoad), app, global);
 
-  const lifecycles = await loadEntry<MicroAppLifeCycles>(entry, microAppContainer, containerOpts);
+  const lifecycles = await lifecyclesPromise;
   if (!lifecycles) throw new QiankunError(`${appName} entry ${entry} load failed as it not export lifecycles`);
   const { bootstrap, mount, unmount, update } = getLifecyclesFromExports(
     lifecycles,