Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: extract API component as a plugin #953

Closed
wants to merge 5 commits into from

Conversation

mortalYoung
Copy link
Collaborator

🤔 这个变动的性质是?/ What is the nature of this change?

  • 新特性提交 / New feature

🔗 相关 Issue / Related Issue

💡 需求背景和解决方案 / Background or solution

📝 更新日志 / Changelog

Language Changelog
🇺🇸 English extract API component as a plugin
🇨🇳 Chinese 将内置 API 组件抽离成插件

@github-actions
Copy link

github-actions bot commented Nov 20, 2021

🎊 PR Preview has been successfully built and deployed to https://dumi-preview-pr-953.surge.sh

@github-actions
Copy link

github-actions bot commented Nov 20, 2021

🎊 PR Mobile Preview has been successfully built and deployed to https://dumi-mobile-preview-pr-953.surge.sh

@mortalYoung
Copy link
Collaborator Author

看了一下还是挺大的,🤣
建议是 review 的时候 select commit 一下,每次 commit 都只做一件事,应该会直观一点🥶

@codecov
Copy link

codecov bot commented Nov 20, 2021

Codecov Report

Merging #953 (ad79e04) into master (37666de) will increase coverage by 0.11%.
The diff coverage is 100.00%.

❗ Current head ad79e04 differs from pull request most recent head 6f8e6d3. Consider uploading reports for the commit 6f8e6d3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #953      +/-   ##
==========================================
+ Coverage   94.74%   94.86%   +0.11%     
==========================================
  Files         117      116       -1     
  Lines        2857     2845      -12     
  Branches      972      970       -2     
==========================================
- Hits         2707     2699       -8     
+ Misses        146      142       -4     
  Partials        4        4              
Impacted Files Coverage Δ
packages/preset-dumi/src/index.ts 100.00% <ø> (ø)
packages/preset-dumi/src/theme/loader.ts 96.20% <ø> (ø)
...ckages/preset-dumi/src/transformer/remark/index.ts 100.00% <ø> (ø)
packages/plugin-dumi-api/src/API.tsx 100.00% <100.00%> (ø)
packages/plugin-dumi-api/src/index.ts 100.00% <100.00%> (ø)
packages/plugin-dumi-api/src/parser.ts 100.00% <100.00%> (ø)
packages/plugin-dumi-api/src/useApiData.ts 100.00% <100.00%> (ø)
packages/preset-dumi/src/theme/layout.tsx 86.88% <0.00%> (-0.42%) ⬇️
packages/preset-dumi/src/loader/index.ts 100.00% <0.00%> (ø)
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 37666de...6f8e6d3. Read the comment docs.

@mortalYoung
Copy link
Collaborator Author

theme.ts#L73 这里的逻辑和目前自定义编译组件的逻辑无法自洽,需要做改造,看下如何改比较好
cc @PeachScript

@PeachScript
Copy link
Member

❤️ 感谢贡献,dumi v1 不再更新,PR 将会关闭;dumi v2 已发布,欢迎继续参与 dumi 的建设,https://d.umijs.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants