Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: externalDemo link broken on windows #27

Merged
merged 1 commit into from
Dec 8, 2019
Merged

fix: externalDemo link broken on windows #27

merged 1 commit into from
Dec 8, 2019

Conversation

Deturium
Copy link
Contributor

@Deturium Deturium commented Dec 6, 2019

No description provided.

@PeachScript PeachScript merged commit 59f2adb into umijs:master Dec 8, 2019
@PeachScript
Copy link
Member

Windows seed user 💯

@xiaohuoni
Copy link
Member

xiaohuoni commented Dec 9, 2019 •
edited
Loading

需要测试一下，文件路径是中文的情况。我之前不知道有这个库，在 umi 中的兼容实现是 slash2 ,可以通过 umi-utils 导出 winPath（我手上没有windows电脑，谁帮忙测试一下）

@PeachScript
Copy link
Member

@Deturium 靠你了，我也没有 Windows 电脑

@Deturium
Copy link
Contributor Author

Deturium commented Dec 9, 2019

.md 文件名是中文没问题
你想试那些 edge case ？

@xiaohuoni
Copy link
Member

xiaohuoni commented Dec 9, 2019 •
edited
Loading

@Deturium 项目路径路径是中文比如 /项目/测试/admin/a.md 这样子。

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Deturium @PeachScript @xiaohuoni