fix: alias layout file resolve bug since [email protected] #1935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeachScript
force-pushed
the
hotfix/revert-alias-route-file
branch
from
cad9cc7 to
946bf0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
Close #1932
💡 需求背景和解决方案 / Background or solution
问题背景：之前 dumi 为了解 chunk name 引起的 CDN 资源托管问题（包括但不限于 #1487 ），用 alias 实现了 chunk name 的优化（见 #1601 ），但这个实现的前提是 layouts 不会被 server loader 处理，因为 server loader 解析 route component 时不会处理 alias，在 umijs/umi#11666 后 layouts 也会被 server loader 处理，导致 4.0.84 发布后 dumi 应用报错
解决方案：不再使用别名的形式来配置路由组件，这种用法与 Umi 最新的改动会冲突，在 Umi 发版后会导致 dumi 编译失败；改为使用绝对路径来配置路由组件，把 chunk name 的简化逻辑交给 Umi 来做 umijs/umi#11716
📝 更新日志 / Changelog