refactor: share markdown absolute path with custom unified plugins #1901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
PeachScript
reviewed
Sep 17, 2023
| @@ -65,6 +65,7 @@ export default function remarkMeta(opts: IRemarkMetaOpts): Transformer<Root> { | |||
| title: '', | |||
| toc: 'menu', | |||
| filename: winPath(path.relative(opts.cwd, opts.fileAbsPath)), | |||
| resourcePath: opts.fileAbsPath, | |||
There was a problem hiding this comment.
建议像 dumi 1 这样通过 unified 的 data 传下去，不依赖插件实现：
内部消费用 this.data('xxx')
PeachScript
reviewed
Sep 17, 2023
| @@ -197,6 +198,13 @@ export default async (raw: string, opts: IMdTransformerOptions) => { | |||
| }), | |||
| ); | |||
|
|
|||
| // information is stored in an object. | |||
| processor.data({ | |||
There was a problem hiding this comment.
先只设置单个 fileAbsPath？应该也不需要 winPath 吧，只有要参与 webpack 编译的内容中的路径需要 winPath
This reverts commit cfaab18.
|
ready~ |
PeachScript
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🤔 这个变动的性质是？/ What is the nature of this change?
🔗 相关 Issue / Related Issue
💡 需求背景和解决方案 / Background or solution
📝 更新日志 / Changelog