Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support opts.fileName #159

Merged
merged 1 commit into from
Jul 31, 2017
Merged

feat: support opts.fileName #159

merged 1 commit into from
Jul 31, 2017

Conversation

paranoidjk
Copy link
Contributor

close #116

[email protected] will change file extension as below ant-design/ant-design-mobile#1235 :

  • .native.js: react native component
  • .js: web component

so no need to rely on webpack.resolve config, which cause trouble in server side render.

[email protected] will suggest users to use babel-plugin-import handle both web component&style import and react-native component import.

@paranoidjk paranoidjk requested a review from yesmeck July 31, 2017 11:04
@sorrycc sorrycc merged commit e9b3ec7 into master Jul 31, 2017
@sorrycc sorrycc deleted the support-fileName branch July 31, 2017 12:36
@sorrycc
Copy link
Member

sorrycc commented Jul 31, 2017

[email protected]

@paranoidjk
Copy link
Contributor Author

Update

react native handle .native by itself. see ant-design/antd-tools#54 (comment)

so antd-mobile won't need babel-plugin-import opts.fileName, but this still can be a feature for potential another usage.

zhanguangao pushed a commit to zhanguangao/babel-plugin-module-federation-import that referenced this pull request Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add suffix option
2 participants