Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update ibc and related deps. #1292

Merged
merged 13 commits into from
Aug 31, 2022
Merged

chore: update ibc and related deps. #1292

merged 13 commits into from
Aug 31, 2022

Conversation

robert-zaremba
Copy link
Member

Description

blocked by: #1285


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • added ! to the type prefix if API or client breaking change
  • added appropriate labels to the PR
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • added a changelog entry to CHANGELOG.md
  • included comments for documenting Go code
  • updated the relevant documentation or specification
  • reviewed "Files changed" and left comments if necessary
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic
  • reviewed API design and naming
  • reviewed documentation is accurate
  • reviewed tests and test coverage
  • manually tested (if applicable)

@robert-zaremba robert-zaremba marked this pull request as ready for review August 30, 2022 22:10
@robert-zaremba robert-zaremba requested review from a team as code owners August 30, 2022 22:10
Copy link
Contributor

@RafilxTenfen RafilxTenfen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, we just need to fix the CI fails

@robert-zaremba
Copy link
Member Author

GetTransferAccount function was deprecated and removed (together with TestGetTransferAccount): cosmos/ibc-go#1250
So I removed that test in our wrapper as well.

@mergify mergify bot merged commit 2180ff1 into main Aug 31, 2022
@mergify mergify bot deleted the robert/ibc-bump branch August 31, 2022 22:53
Copy link
Contributor

@khoerling khoerling left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testing locally...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants