-
Notifications
You must be signed in to change notification settings - Fork 170
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: bump umee to v3 #1283
Merged
chore: bump umee to v3 #1283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixing golint issue: #1284 |
RafilxTenfen
approved these changes
Aug 25, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, can we push a new tag after this gets merged?
we should tag only after we merge #1285 |
rbajollari
pushed a commit
that referenced
this pull request
Aug 26, 2022
## Description closes: #1282 --- ### Author Checklist _All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues._ I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] added appropriate labels to the PR - [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist _All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items._ I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
rbajollari
pushed a commit
that referenced
this pull request
Aug 26, 2022
## Description closes: #1282 --- ### Author Checklist _All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues._ I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] added appropriate labels to the PR - [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist _All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items._ I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable)
adamewozniak
added a commit
that referenced
this pull request
Aug 26, 2022
* Use viper in price-feeder config * update CHANGELOG.md with #1274 * address pr suggestions * chore: update codeowners (#1275) * Run go fmt * fix: use http.Status* codes (#1284) * Update price-feeder/CHANGELOG.md Co-authored-by: Adam Wozniak <[email protected]> * build(deps): Bump github.com/golangci/golangci-lint from 1.48.0 to 1.49.0 (#1277) Bumps [github.com/golangci/golangci-lint](https://github.com/golangci/golangci-lint) from 1.48.0 to 1.49.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/releases">github.com/golangci/golangci-lint's releases</a>.</em></p> <blockquote> <h2>v1.49.0</h2> <h2>Changelog</h2> <ul> <li>69a49cf6 build(deps): bump github.com/GaijinEntertainment/go-exhaustruct/v2 from 2.2.2 to 2.3.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3122">#3122</a>)</li> <li>9da04f50 build(deps): bump github.com/go-critic/go-critic from 0.6.3 to 0.6.4 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3089">#3089</a>)</li> <li>1bb23af9 build(deps): bump github.com/mattn/go-colorable from 0.1.12 to 0.1.13 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3123">#3123</a>)</li> <li>be10ef26 build(deps): bump github.com/mgechev/revive from 1.2.1 to 1.2.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3075">#3075</a>)</li> <li>1ca9affe build(deps): bump github.com/mgechev/revive from 1.2.2 to 1.2.3 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3091">#3091</a>)</li> <li>f78f6dd3 build(deps): bump github.com/polyfloyd/go-errorlint from 1.0.0 to 1.0.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3092">#3092</a>)</li> <li>edeaa17f build(deps): bump github.com/polyfloyd/go-errorlint from 1.0.1 to 1.0.2 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3097">#3097</a>)</li> <li>14714050 build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.10.0 to 1.13.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3120">#3120</a>)</li> <li>0e044f25 build(deps): bump github.com/sashamelentyev/usestdlibvars from 1.8.0 to 1.10.0 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3090">#3090</a>)</li> <li>d57145d4 build(deps): bump github.com/securego/gosec/v2 from 2.12.0 to 2.13.1 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3119">#3119</a>)</li> <li>a813244b build(deps): bump github.com/shirou/gopsutil/v3 from 3.22.6 to 3.22.7 (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3074">#3074</a>)</li> <li>cc2d97f3 contextcheck: bump to v1.0.6 && re-enable (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3102">#3102</a>)</li> <li>63b2fe00 feat: add interfacebloat (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3024">#3024</a>)</li> <li>f48530e2 feat: add logrlint (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3093">#3093</a>)</li> <li>58809c3b feat: add reassign linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3064">#3064</a>)</li> <li>37d3aa43 feat: deprecate varcheck, deadcode, and structcheck (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3125">#3125</a>)</li> <li>da3b1496 fix: exit early on run --version (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3067">#3067</a>)</li> <li>970b0a5b fix: set an explicit GOROOT in the Docker image for go-critic (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3106">#3106</a>)</li> <li>d4fd2db3 nosnakecase: deprecate linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3065">#3065</a>)</li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/golangci/golangci-lint/blob/master/CHANGELOG.md">github.com/golangci/golangci-lint's changelog</a>.</em></p> <blockquote> <h3>v1.49.0</h3> <p>IMPORTANT: <code>varcheck</code> and <code>deadcode</code> has been removed of default linters.</p> <ol> <li>new linters <ul> <li><code>interfacebloat</code>: <a href="https://github.com/sashamelentyev/interfacebloat">https://github.com/sashamelentyev/interfacebloat</a></li> <li><code>logrlint</code>: <a href="https://github.com/timonwong/logrlint">https://github.com/timonwong/logrlint</a></li> <li><code>reassign</code>: <a href="https://github.com/curioswitch/go-reass">https://github.com/curioswitch/go-reass</a></li> </ul> </li> <li>updated linters <ul> <li><code>go-colorable</code>: from 0.1.12 to 0.1.13</li> <li><code>go-critic</code>: from 0.6.3 to 0.6.4</li> <li><code>go-errorlint</code>: from 1.0.0 to 1.0.2</li> <li><code>go-exhaustruct</code>: from 2.2.2 to 2.3.0</li> <li><code>gopsutil</code>: from 3.22.6 to 3.22.7</li> <li><code>gosec</code>: from 2.12.0 to 2.13.1</li> <li><code>revive</code>: from 1.2.1 to 1.2.3</li> <li><code>usestdlibvars</code>: from 1.8.0 to 1.13.0</li> <li><code>contextcheck</code>: from v1.0.4 to v1.0.6 && re-enable</li> <li><code>nosnakecase</code>: This linter is deprecated.</li> <li><code>varcheck</code>: This linter is deprecated use <code>unused</code> instead.</li> <li><code>deadcode</code>: This linter is deprecated use <code>unused</code> instead.</li> <li><code>structcheck</code>: This linter is deprecated use <code>unused</code> instead.</li> </ul> </li> <li>documentation <ul> <li><code>revive</code>: fix wrong URL</li> <li>Add a section about default exclusions</li> <li><code>usestdlibvars</code>: fix typo in documentation</li> <li><code>nolintlint</code>: remove allow-leading-space option</li> <li>Update documentation and assets</li> </ul> </li> <li>misc. <ul> <li>dev: rewrite the internal tests framework</li> <li>fix: exit early on run --version</li> <li>fix: set an explicit <code>GOROOT</code> in the Docker image for <code>go-critic</code></li> </ul> </li> </ol> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/golangci/golangci-lint/commit/cc2d97f31dea62c47c55d5b7a93637e242df7ad1"><code>cc2d97f</code></a> contextcheck: bump to v1.0.6 && re-enable (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3102">#3102</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/58809c3bf5d4e94500f7880978b6eb5e204f0f96"><code>58809c3</code></a> feat: add reassign linter (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3064">#3064</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/77962e92832feaf1e2e9056bc66869fa0e6ebc5d"><code>77962e9</code></a> dev: fix linter tests (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3128">#3128</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/f48530e25ea0b1db098c025a27348a720c4492b7"><code>f48530e</code></a> feat: add logrlint (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3093">#3093</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/320a18eb372f5a1084b038633095a3955c806d9b"><code>320a18e</code></a> dev: concat string</li> <li><a href="https://github.com/golangci/golangci-lint/commit/3aea4ce9ced663f34beb27a7c944c0eac68d778f"><code>3aea4ce</code></a> fix: flaky tests</li> <li><a href="https://github.com/golangci/golangci-lint/commit/37d3aa437a9192ae167c71e63719ddf1c858be7f"><code>37d3aa4</code></a> feat: deprecate varcheck, deadcode, and structcheck (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3125">#3125</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/e1afce44332c177ae56e3fd8e6d0b1d6250d7b3f"><code>e1afce4</code></a> dev: improve runner to run dir with go.mod (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3124">#3124</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/970b0a5bd7568f3a2b69f0af49be092c7a378307"><code>970b0a5</code></a> fix: set an explicit GOROOT in the Docker image for go-critic (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3106">#3106</a>)</li> <li><a href="https://github.com/golangci/golangci-lint/commit/63b2fe004847ccbe4d744f392e749d575dd77be8"><code>63b2fe0</code></a> feat: add interfacebloat (<a href="https://github-redirect.dependabot.com/golangci/golangci-lint/issues/3024">#3024</a>)</li> <li>Additional commits viewable in <a href="https://github.com/golangci/golangci-lint/compare/v1.48.0...v1.49.0">compare view</a></li> </ul> </details> <br /> [![Dependabot compatibility score](https://dependabot-badges.githubapp.com/badges/compatibility_score?dependency-name=github.com/golangci/golangci-lint&package-manager=go_modules&previous-version=1.48.0&new-version=1.49.0)](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> * chore: bump umee to v3 (#1283) ## Description closes: #1282 --- ### Author Checklist _All items are required. Please add a note to the item if the item is not applicable and please add links to any relevant follow up issues._ I have... - [ ] included the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] added `!` to the type prefix if API or client breaking change - [ ] added appropriate labels to the PR - [ ] targeted the correct branch (see [PR Targeting](https://github.com/umee-network/umee/blob/main/CONTRIBUTING.md#pr-targeting)) - [ ] provided a link to the relevant issue or specification - [ ] added a changelog entry to `CHANGELOG.md` - [ ] included comments for [documenting Go code](https://blog.golang.org/godoc) - [ ] updated the relevant documentation or specification - [ ] reviewed "Files changed" and left comments if necessary - [ ] confirmed all CI checks have passed ### Reviewers Checklist _All items are required. Please add a note if the item is not applicable and please add your handle next to the items reviewed if you only reviewed selected items._ I have... - [ ] confirmed the correct [type prefix](https://github.com/commitizen/conventional-commit-types/blob/v3.0.0/index.json) in the PR title - [ ] confirmed all author checklist items have been addressed - [ ] reviewed state machine logic - [ ] reviewed API design and naming - [ ] reviewed documentation is accurate - [ ] reviewed tests and test coverage - [ ] manually tested (if applicable) * ci: lint file patterns (#1286) Co-authored-by: Adam Wozniak <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
closes: #1282
Author Checklist
All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.
I have...
!
to the type prefix if API or client breaking changeCHANGELOG.md
Reviewers Checklist
All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.
I have...