feat: add GCP logs #394
Merged
feat: add GCP logs #394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RafilxTenfen
commented
Oct 24, 2022
RafilxTenfen
commented
- Added new flags to specify the GCP project to send logs to
- the user is going to have to specify credentials if he wants to send logs to GCP, otherwise, it will continue with the orchestrator process
… into rafilx/peggo-gcp-logs
robert-zaremba
approved these changes
Oct 25, 2022
Co-authored-by: Robert Zaremba <[email protected]>
Co-authored-by: Robert Zaremba <[email protected]>
mergify bot
pushed a commit
that referenced
this pull request
Oct 26, 2022
* add GCP logging to peggo * add flag to specify the project name * add flags to get log level and moniker to easy searching * set default as info * add readme section for gcp logging * go mod tidy * Apply suggestions from code review Co-authored-by: Robert Zaremba <[email protected]> * Update README.md Co-authored-by: Robert Zaremba <[email protected]> * add example how to set gcp credentials Co-authored-by: Adam Moser <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> (cherry picked from commit 33a035b) # Conflicts: # go.mod # go.sum
facundomedica
pushed a commit
that referenced
this pull request
Oct 26, 2022
* feat: add GCP logs (#394) * add GCP logging to peggo * add flag to specify the project name * add flags to get log level and moniker to easy searching * set default as info * add readme section for gcp logging * go mod tidy * Apply suggestions from code review Co-authored-by: Robert Zaremba <[email protected]> * Update README.md Co-authored-by: Robert Zaremba <[email protected]> * add example how to set gcp credentials Co-authored-by: Adam Moser <[email protected]> Co-authored-by: Robert Zaremba <[email protected]> (cherry picked from commit 33a035b) # Conflicts: # go.mod # go.sum * fix imports Co-authored-by: Rafael Tenfen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.