LIBDRUM-827. Keep bitstream download count separate from file hyperlink #62
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In the DSpace 7.6 upgrade, this file was modified to match the stock DSpace file in which the "ngFor" iterator was part of the "ds-themed-file-download-link" component, and the "ds-bitstream-download-counter" component was part of the "ds-themed-file-download-link" content. This caused an issue in which the bitstream download count was included as part of the file hyperlink. Fixed the issue by moving the "ngFor" iterator into a separate "ngContainer", and moving the "ds-bitstream-download-counter" component out of the content of the "ds-themed-file-download-link" component. https://umd-dit.atlassian.net/browse/LIBDRUM-827
Moved the "No. of downloads:" text for the label used by the "ds-bitstream-download-counter" component into the "en.json5" file. This was done to maintain consistent use of I18n text. https://umd-dit.atlassian.net/browse/LIBDRUM-827
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the DSpace 7.6 upgrade, this file was modified to match the stock
DSpace file in which the "ngFor" iterator was part of the
"ds-themed-file-download-link" component, and the
"ds-bitstream-download-counter" component was part of the
"ds-themed-file-download-link" content. This caused an issue in which
the bitstream download count was included as part of the file hyperlink.
Fixed the issue by moving the "ngFor" iterator into a separate
"ngContainer", and moving the "ds-bitstream-download-counter" component
out of the content of the "ds-themed-file-download-link" component.
Also, moved the "No. of downloads:" text for the label used by the
"ds-bitstream-download-counter" component into the "en.json5" file.
This was done to maintain consistent use of I18n text.
https://umd-dit.atlassian.net/browse/LIBDRUM-827