LIBFCREPO-1460. Fix "ControlledURIRef" delete when "Repeatable" #435
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added an optional "edit_only" field to the content model definition to enable specific fields, such as "Presentation Set" to not be displayed on the item detail page. This is needed because otherwise the "Presentation Set" field would be shown twice on the item detail page -- once for the Solr-based field specified in the “app/controllers/catalog_controller.rb” configuration and once for the Fedora-based field specified in the “config/content_models.yml” file. Based on June 26, 2024 WebEx discussions in the “Fedora” channel with Josh Westgard, the preference is to display the Solr field on the item detail page because: > ... that way we know that the update has "stuck" all the way through > the stack. So even though there is a delay associated with making > such a change, in the long run this is better for display in Archelon. Modified the "_show_default.html.erb" file to skip display of any fields where the "edit_only" field is true. Updated the "ContentModelDefinitions.md" documentation. https://umd-dit.atlassian.net/browse/LIBFCREPO-1458
In LIBHYDRA-356, a "componentWillUnmount" method was added to the React components to support deletion when used with the "Repeatable" React component. The "ControlledURIRef" component apparently missed in the update. Added the "componentWillUnmount" to fix the issue with deleting entries when the "ControlledURIRef" component is used with a "Repeatable" React component. https://umd-dit.atlassian.net/browse/LIBFCREPO-1460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In LIBHYDRA-356, a "componentWillUnmount" method was added to the React
components to support deletion when used with the "Repeatable" React
component. The "ControlledURIRef" component apparently missed in the
update.
Added the "componentWillUnmount" to fix the issue with deleting entries
when the "ControlledURIRef" component is used with a "Repeatable" React
component.
https://umd-dit.atlassian.net/browse/LIBFCREPO-1460