LIBHYDRA-577: Updating about controller to ping Solr #398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When visiting the about page, pinging solr so that when refreshing the user can be sure that Solr is back up again. Previously refreshing the page would have user's think the service was back up. Now a flash screen will appear on refresh's of the page. https://umd-dit.atlassian.net/browse/LIBHYDRA-577
…rror methods. - put the common code into the application controller (logging and setting the flash message) - replaced the Solr error handler in the catalog_controller with goto_about_page, which calls solr_connection_error then does the redirect https://umd-dit.atlassian.net/browse/LIBHYDRA-577
peichman-umd
requested changes
Apr 18, 2024
There was a problem hiding this comment.
Looks good. See one suggested change to consolidate the catalog and static_pages solr_connection_error methods in PR #5
LIBHYDRA-577. Combined the catalog and static_pages solr_connection_error methods.
|
Merged the changes requested |
peichman-umd
approved these changes
Apr 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When visiting the about page, pinging solr so that when refreshing the user can be sure that Solr is back up again. Previously refreshing the page would have user's think the service was back up. Now a flash screen will appear on refresh's of the page.
https://umd-dit.atlassian.net/browse/LIBHYDRA-577