LIBHYDRA-548: Configuraiton for communicating with Plastron for Publish Jobs #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Publish job additions
Using form_with instead for the checkbox and form submission and updated the check for visbility in the submit method https://umd-dit.atlassian.net/browse/LIBHYDRA-548
Adding hidden flag for the Plastron command Updated the visibility variable in publish_job to force_hidden https://umd-dit.atlassian.net/browse/LIBHYDRA-548
- Renamed PublishJobController to PublishJobsController - Use resourceful routing in the routes.rb config - Use the URL-helper functions instead of hard-coding URLs - Changed the label of the force_hidden checkbox to fit the logic of the flag: "Suppress these items in search results" - Fixed join character in the message body for the publish message
Parallels the other *JobsChannel classes
Code review for LIBHYDRA-548
Adding status messages for the different states of the publish job Removing old code to set the state to use the partial status html instead Also added some breaks between the buttons when viewing. https://umd-dit.atlassian.net/browse/LIBHYDRA-548
peichman-umd
reviewed
Mar 5, 2024
app/models/publish_job.rb
Outdated
| publish_in_progress: 3, | ||
| publish_complete: 4, | ||
| publish_incomplete: 5, | ||
| publish_error: 6 |
There was a problem hiding this comment.
Plastron also returns unpublish_complete, unpublish_incomplete, and unpublish_error, so those need to be added to this enum.
peichman-umd
requested changes
Mar 5, 2024
These states are returned by plastron https://umd-dit.atlassian.net/browse/LIBHYDRA-548
peichman-umd
approved these changes
Mar 5, 2024
|
The tests are failing because of a mismatch between the final db schema and the test fixtures. |
Fixed failing tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://umd-dit.atlassian.net/browse/LIBHYDRA-548