Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: docker minio example #232

Merged
merged 8 commits into from
Mar 21, 2024
Merged

docs: docker minio example #232

merged 8 commits into from
Mar 21, 2024

Conversation

mmalenic
Copy link
Member

@mmalenic mmalenic commented Mar 20, 2024

Fixes #231

Changes

  • Add complete MinIO example with a docker compose showing specific configuration considerations.
  • Minimise docker image by using gcr.io/distroless/cc-debian12.
  • Rearrange examples and some README instructions.
  • Remove differing behaviour of the default storage type when compiling with and without the s3-storage feature flag.

@mmalenic mmalenic requested a review from brainstorm March 20, 2024 03:25
@mmalenic mmalenic enabled auto-merge March 20, 2024 04:13
Copy link
Member

@brainstorm brainstorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know what you think about including the additional MinIO DNS S3 bucket style context as it might become relevant again in the future when and if only one of the two styles is officially supported in both AWS and MiniO.

Other than this small detail, great PR!

deploy/examples/minio/README.md Outdated Show resolved Hide resolved
deploy/Dockerfile Show resolved Hide resolved
deploy/Dockerfile Show resolved Hide resolved
@mmalenic mmalenic added this pull request to the merge queue Mar 21, 2024
Merged via the queue into main with commit 1446dbb Mar 21, 2024
4 checks passed
@mmalenic mmalenic deleted the docs/docker-minio-example branch September 24, 2024 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: improve documentation for MinIO
2 participants