Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix compatibility latest version of Laravel with laravel/framework#49264 #83

Merged

Conversation

KentarouTakeda
Copy link
Contributor

This Pull Request is a follow up of #82 by @mpyw.

After the previous Pull Request was created, laravel/framework#49264 provided a new method with the same name as our library:

https://github.com/laravel/framework/pull/49264/files#diff-1a147b8174f4809f7471525e9d676e831176efdbeb69af8af6e95c1a72aef962R366-R373

Fix it using the same idea as last time.

NOTE:

  • According to [11.x] Remove Doctrine DBAL laravel/framework#48864, the series of tasks on the framework side seems to have been completed, so the same fix will no longer be necessary in the future.
  • IMO: Currently, our library does not work with the latest version of Laravel, so we SHOULD apply this Pull Request. However, I think that we MAY NOT override the framework's behavior, so if compatibility is confirmed, we MAY adopt the framework's method and remove our code.

@pvsaintpe pvsaintpe merged commit 190ae7a into umbrellio:master Dec 22, 2023
5 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants