Update routing: #5896
Merged
Update routing: #5896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @erikjanwestendorp thank you for the PR! The CMS changes looks good, however I have talked over with the team if we should accept AKA as acronym and we have agreed that it is not obvious/clear what it means and should not be used ideally. Therefore this is something that we will not accept 🙏 I have also looked it up on google and it is not recommended for a documentation either 🙈 |
|
@alina-tincas Thanks for your review! Just updated the PR 😄 |
alina-tincas
approved these changes
Mar 6, 2024
|
Thank you for understanding and for making the necessary changes! All looks good so am merging this in 😊 💪 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update routing:
Add 'AKA' to exceptions listType of suggestion
Product & version (if relevant)
Umbraco CMS v10, 12 & 13