umbraco · nielslyngsoe · Nov 20, 2024 · Nov 7, 2024 · Nov 7, 2024 · Nov 7, 2024
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,16 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+### Bug Fixes
+
+- Add pointer cursor to color picker button ([#936](https://github.com/umbraco/Umbraco.UI/issues/936)) ([86c4fce](https://github.com/umbraco/Umbraco.UI/commit/86c4fce113530f7bf95b4a738ae4f60a099de224))
+
+### Features
+
+- make actions container visible on focus-within ([#949](https://github.com/umbraco/Umbraco.UI/issues/949)) ([29cfe66](https://github.com/umbraco/Umbraco.UI/commit/29cfe66a2f6fd0d27f342ebd91b14f537be3c286))
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 ### Bug Fixes

diff --git a/docs/RELEASE_INSTRUCTION.md b/docs/RELEASE_INSTRUCTION.md
@@ -1,9 +1,7 @@
 # UI Library Release workflow
 
-1. Create a new branch for the release. We need a good naming convention: `Release/<patch/minor/major>-<YYMMDD>` (example: `Release/Patch-220128`).
-1. **Important:** At this step it is essential to generate the release notes for the new release, because they are made by comparing the current changes with the previous release. Run the command `npm run lerna:changelog` to generate the release notes into the console and make a copy of them to use later for Github Releases. It is not possible to run later due to new tags.
-   1. You probably need to generate a Github token with the "repo" access for this. [Generate one on Github](https://github.com/settings/tokens/new) to do so.
-1. Review new release PR (either [on GitHub](https://github.com/umbraco/Umbraco.UI/compare/) or through `npm run lerna:diff`).
+1. Create a new branch for the release. We need a good naming convention: `release/<Version>` (example: `release/1.12.0`).
+1. Review new release PR (either [on GitHub](https://github.com/umbraco/Umbraco.UI/compare/)).
 1. Make a PR from the new branch to the `main` branch.
 1. Run `npm run lerna:version` and Lerna will suggest a version bump for each package.
 1. Review the new version numbers and accept with `y` and Lerna will now bump each package and update the local CHANGELOG.md file using descriptions from the conventional commits, Lerna will also reinstall NPM and generate a new lockfile.

diff --git a/lerna.json b/lerna.json
@@ -1,7 +1,7 @@
 {
   "$schema": "node_modules/@lerna-lite/cli/schemas/lerna-schema.json",
   "packages": ["packages/*"],
-  "version": "1.11.0",
+  "version": "1.12.0",
   "preid": "rc",
   "exact": true,
   "noPush": true,

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -120,7 +120,7 @@
     "react-syntax-highlighter": "15.5.0",
     "remark-gfm": "3.0.1",
     "rimraf": "5.0.5",
-    "rollup": "4.9.6",
+    "rollup": "4.27.2",
     "rollup-plugin-esbuild": "6.1.1",
     "rollup-plugin-import-css": "3.5.5",
     "rollup-plugin-minify-html-literals": "1.2.6",

diff --git a/packages/uui-action-bar/CHANGELOG.md b/packages/uui-action-bar/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-action-bar
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-action-bar

diff --git a/packages/uui-action-bar/package.json b/packages/uui-action-bar/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-action-bar",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "keywords": [
     "Umbraco",
@@ -30,8 +30,8 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.11.0",
-    "@umbraco-ui/uui-button-group": "1.11.0"
+    "@umbraco-ui/uui-base": "1.12.0",
+    "@umbraco-ui/uui-button-group": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",

diff --git a/packages/uui-avatar-group/CHANGELOG.md b/packages/uui-avatar-group/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-avatar-group
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-avatar-group

diff --git a/packages/uui-avatar-group/package.json b/packages/uui-avatar-group/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-avatar-group",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "keywords": [
     "Umbraco",
@@ -30,8 +30,8 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-avatar": "1.11.0",
-    "@umbraco-ui/uui-base": "1.11.0"
+    "@umbraco-ui/uui-avatar": "1.12.0",
+    "@umbraco-ui/uui-base": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",

diff --git a/packages/uui-avatar/CHANGELOG.md b/packages/uui-avatar/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-avatar
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-avatar

diff --git a/packages/uui-avatar/package.json b/packages/uui-avatar/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-avatar",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "description": "An avatar web component for displaying user avatars.",
   "keywords": [
@@ -30,7 +30,7 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.11.0"
+    "@umbraco-ui/uui-base": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",

diff --git a/packages/uui-badge/CHANGELOG.md b/packages/uui-badge/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-badge
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-badge

diff --git a/packages/uui-badge/package.json b/packages/uui-badge/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-badge",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "description": "A badge to notify that there is something that requires attention of the user.",
   "keywords": [
@@ -30,7 +30,7 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.11.0"
+    "@umbraco-ui/uui-base": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",

diff --git a/packages/uui-base/CHANGELOG.md b/packages/uui-base/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-base
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 ### Bug Fixes

diff --git a/packages/uui-base/lib/mixins/SelectableMixin.ts b/packages/uui-base/lib/mixins/SelectableMixin.ts
@@ -54,8 +54,8 @@ export const SelectableMixin = <T extends Constructor<LitElement>>(
       const oldVal = this._selectable;
       this._selectable = newVal;
       // Potentially problematic as a component might need focus for another feature when not selectable:
-      if (!this.selectableTarget) {
-        // If not selectable target, then make it self selectable. (A selectable target should be made focusable by the component itself)
+      if (this.selectableTarget === this) {
+        // If the selectable target, then make it self selectable. (A different selectable target should be made focusable by the component itself)
         this.setAttribute('tabindex', `${newVal ? '0' : '-1'}`);
       }
       this.requestUpdate('selectable', oldVal);
@@ -80,10 +80,16 @@ export const SelectableMixin = <T extends Constructor<LitElement>>(
     }
 
     private handleSelectKeydown = (e: KeyboardEvent) => {
-      //if (e.composedPath().indexOf(this.selectableTarget) !== -1) {
-      if (this.selectableTarget === this) {
-        if (e.key !== ' ' && e.key !== 'Enter') return;
-        this._toggleSelect();
+      const composePath = e.composedPath();
+      if (
+        (this._selectable || (this.deselectable && this.selected)) &&
+        composePath.indexOf(this.selectableTarget) === 0
+      ) {
+        if (this.selectableTarget === this) {
+          if (e.code !== 'Space' && e.code !== 'Enter') return;
+          this._toggleSelect();
+          e.preventDefault();
+        }
       }
     };
 
@@ -112,7 +118,7 @@ export const SelectableMixin = <T extends Constructor<LitElement>>(
     }
 
     private _toggleSelect() {
-      // Only allow for select-interaction if selectable is true. Deselectable is ignorered in this case, we do not want a DX where only deselection is a possibility..
+      // Only allow for select-interaction if selectable is true. Deselectable is ignored in this case, we do not want a DX where only deselection is a possibility..
       if (!this.selectable) return;
       if (this.deselectable === false) {
         this._select();

diff --git a/packages/uui-base/package.json b/packages/uui-base/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-base",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "keywords": [
     "Umbraco",

diff --git a/packages/uui-boolean-input/CHANGELOG.md b/packages/uui-boolean-input/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-boolean-input
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-boolean-input

diff --git a/packages/uui-boolean-input/lib/uui-boolean-input.element.ts b/packages/uui-boolean-input/lib/uui-boolean-input.element.ts
@@ -114,14 +114,14 @@ export abstract class UUIBooleanInputElement extends UUIFormControlMixin(
       this._value = 'on';
     }
     this.inputRole = inputRole;
-    this.addEventListener('keypress', this._onKeypress);
+    this.addEventListener('keydown', this.#onKeyDown);
   }
 
   protected getFormElement(): HTMLInputElement {
     return this._input;
   }
 
-  private _onKeypress(e: KeyboardEvent): void {
+  #onKeyDown(e: KeyboardEvent): void {
     if (e.key == 'Enter') {
       this.submit();
     }

diff --git a/packages/uui-boolean-input/lib/uui-boolean-input.test.ts b/packages/uui-boolean-input/lib/uui-boolean-input.test.ts
@@ -128,8 +128,8 @@ describe('BooleanInputBaseElement in a Form', () => {
 
   describe('submit', () => {
     it('should submit when pressing enter', async () => {
-      const listener = oneEvent(formElement, 'submit', false);
-      element.dispatchEvent(new KeyboardEvent('keypress', { key: 'Enter' }));
+      const listener = oneEvent(formElement, 'submit');
+      element.dispatchEvent(new KeyboardEvent('keydown', { key: 'Enter' }));
 
       const event = await listener;
       expect(event).to.exist;

diff --git a/packages/uui-boolean-input/package.json b/packages/uui-boolean-input/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-boolean-input",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "keywords": [
     "Umbraco",
@@ -30,7 +30,7 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.11.0"
+    "@umbraco-ui/uui-base": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",

diff --git a/packages/uui-box/CHANGELOG.md b/packages/uui-box/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-box
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-box

diff --git a/packages/uui-box/package.json b/packages/uui-box/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-box",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "description": "A box web component for grouping elements",
   "keywords": [
@@ -29,8 +29,8 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.11.0",
-    "@umbraco-ui/uui-css": "1.11.0"
+    "@umbraco-ui/uui-base": "1.12.0",
+    "@umbraco-ui/uui-css": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",

diff --git a/packages/uui-breadcrumbs/CHANGELOG.md b/packages/uui-breadcrumbs/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-breadcrumbs
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-breadcrumbs

diff --git a/packages/uui-breadcrumbs/package.json b/packages/uui-breadcrumbs/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-breadcrumbs",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "keywords": [
     "Umbraco",
@@ -32,7 +32,7 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.11.0"
+    "@umbraco-ui/uui-base": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",

diff --git a/packages/uui-button-group/CHANGELOG.md b/packages/uui-button-group/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-button-group
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-button-group

diff --git a/packages/uui-button-group/package.json b/packages/uui-button-group/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-button-group",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "description": "An element to group buttons.",
   "keywords": [
@@ -31,7 +31,7 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.11.0"
+    "@umbraco-ui/uui-base": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",

diff --git a/packages/uui-button-inline-create/CHANGELOG.md b/packages/uui-button-inline-create/CHANGELOG.md
@@ -3,6 +3,10 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [1.12.0](https://github.com/umbraco/Umbraco.UI/compare/v1.11.0...v1.12.0) (2024-11-20)
+
+**Note:** Version bump only for package @umbraco-ui/uui-button-inline-create
+
 # [1.11.0](https://github.com/umbraco/Umbraco.UI/compare/v1.10.1...v1.11.0) (2024-10-14)
 
 **Note:** Version bump only for package @umbraco-ui/uui-button-inline-create

diff --git a/packages/uui-button-inline-create/package.json b/packages/uui-button-inline-create/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@umbraco-ui/uui-button-inline-create",
-  "version": "1.11.0",
+  "version": "1.12.0",
   "license": "MIT",
   "keywords": [
     "Umbraco",
@@ -30,7 +30,7 @@
     "custom-elements.json"
   ],
   "dependencies": {
-    "@umbraco-ui/uui-base": "1.11.0"
+    "@umbraco-ui/uui-base": "1.12.0"
   },
   "scripts": {
     "build": "npm run analyze && tsc --build && rollup -c rollup.config.js",