Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(uui-popover-container): remove the Firefox popover polyfill #858

Merged
merged 7 commits into from
Jul 24, 2024
Merged

feat(uui-popover-container): remove the Firefox popover polyfill #858

merged 7 commits into from
Jul 24, 2024

Conversation

iOvergaard
Copy link
Contributor

@iOvergaard iOvergaard commented Jul 18, 2024 •
edited by JesmoDev
Loading

Description

Firefox now supports the Popover API so we no longer need this polyfill.

Updates the test github action to now also update the Playwright Browsers

@iOvergaard iOvergaard added the feature Something we are looking to build label Jul 18, 2024
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-858.westeurope.azurestaticapps.net

@iOvergaard iOvergaard changed the title Remove the Firefox popover polyfill feat(uui-popover-container): remove the Firefox popover polyfill Jul 19, 2024
@iOvergaard iOvergaard requested a review from JesmoDev July 23, 2024 07:34
@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-858.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-858.westeurope.azurestaticapps.net

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-858.westeurope.azurestaticapps.net

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@github-actions GitHub Actions
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-858.westeurope.azurestaticapps.net

JesmoDev
JesmoDev approved these changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@JesmoDev JesmoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iOvergaard iOvergaard merged commit d26635f into v1/contrib Jul 24, 2024
8 checks passed
@iOvergaard iOvergaard deleted the v1/feature/firefox-polyfill-not-needed branch July 24, 2024 06:53
iOvergaard added a commit that referenced this pull request Jul 25, 2024
@iOvergaard @JesmoDev
feat(uui-popover-container): remove the Firefox popover polyfill (#858)
a8d87b5 
* feat: remove the Firefox polyfill as Firefox now natively supports the Popover API

* test: add test for `popover` attribute

* package json

* revert package lock

* update package lock

* update github action to install all playwright dependencies

---------

Co-authored-by: JesmoDev <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JesmoDev JesmoDev JesmoDev approved these changes

Assignees
No one assigned
Labels
feature Something we are looking to build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@iOvergaard @JesmoDev