Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: uui-combobox should correctly handle the active item #682

Merged
merged 2 commits into from
Dec 14, 2023

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Dec 5, 2023

This PR Fixes issues with how the combobox handles the active item. Meaning the one that gets highlighted when you navigate with the arrow keys or click an item.
Before the active item was unreliable and not correctly shown visually.

This PR also correctly sets the first item as active when you open the combobox, or make changes to the children, eg. when you search. Example: If you search for "ora" and the first item is orange, pressing space will now pick orange.
Before you would have to click the item, or navigate to it using the arrow keys before pressing enter.

Also adds the expand symbol instead of the custom svg implementation.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

github-actions bot commented Dec 5, 2023

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-682.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the bug Something isn't working label Dec 14, 2023
@iOvergaard iOvergaard changed the title Feature/combobox update fix: uui-combobox should correctly handle the active item Dec 14, 2023
@iOvergaard iOvergaard merged commit a438b03 into v1/contrib Dec 14, 2023
10 of 11 checks passed
@iOvergaard iOvergaard deleted the feature/combobox-update branch December 14, 2023 13:11
@JesmoDev JesmoDev requested review from nielslyngsoe and removed request for nielslyngsoe December 14, 2023 22:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants