fix: uui-combobox should correctly handle the active item #682
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR Fixes issues with how the combobox handles the active item. Meaning the one that gets highlighted when you navigate with the arrow keys or click an item.
Before the active item was unreliable and not correctly shown visually.
This PR also correctly sets the first item as active when you open the combobox, or make changes to the children, eg. when you search. Example: If you search for "ora" and the first item is orange, pressing space will now pick orange.
Before you would have to click the item, or navigate to it using the arrow keys before pressing enter.
Also adds the expand symbol instead of the custom svg implementation.
Types of changes
Checklist