Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds header-actions slot to uui-box #676

Merged
merged 4 commits into from
Nov 30, 2023

Conversation

nathanwoulfe
Copy link
Contributor

Description

To allow additional controls in the box header, I've added a new slot, header-actions which renders on the right side of the header. This is something I needed for Workflow, but will also be used for the rollback/history panel on Document Info.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Screenshots (if appropriate)

image

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-676.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe self-requested a review November 30, 2023 09:14
Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-676.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-676.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-676.westeurope.azurestaticapps.net

Copy link
Member

@nielslyngsoe nielslyngsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did refactor slightly to get rid of the 'header-left' element. As that was not stricly necessary :-)

Very well done with tests and description corections and story updates!!

@nielslyngsoe nielslyngsoe enabled auto-merge (squash) November 30, 2023 10:07
@nielslyngsoe nielslyngsoe merged commit b3df44b into v1/contrib Nov 30, 2023
9 of 10 checks passed
@nielslyngsoe nielslyngsoe deleted the feature/box-header-actions branch November 30, 2023 10:10
@bjarnef
Copy link
Contributor

bjarnef commented Nov 30, 2023

@nielslyngsoe just though if actions is the best wording? Could it be used for something that isn't an action like a notice or info?
Maybe header-extra / header-extras ?

@bjarnef
Copy link
Contributor

bjarnef commented May 23, 2024

It seems this affected a bit packages which used headline slot. Even though header-actions isn't used, it seems to take up take space.
ByteCrumb/Umbraco.Community.DeliveryApiExtensions#32

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants