Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust components to new icon set #675

Merged
merged 1 commit into from
Nov 30, 2023

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Nov 29, 2023

Correct icons and implementation.

Purpose:

Get the right look of icon and get the right colors.
And fix the look as this did un intentional change when all the icons where switched out ofr Lucide icons.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-675.westeurope.azurestaticapps.net

@nielslyngsoe nielslyngsoe marked this pull request as ready for review November 29, 2023 15:46
@nielslyngsoe nielslyngsoe requested review from JesmoDev and loivsen and removed request for iOvergaard and JesmoDev November 29, 2023 15:46
Copy link
Contributor

@JesmoDev JesmoDev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nielslyngsoe nielslyngsoe merged commit b7e71f5 into v1/contrib Nov 30, 2023
10 of 11 checks passed
@nielslyngsoe nielslyngsoe deleted the v1/bugfix/fix-new-svgs-colorouring branch November 30, 2023 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants