Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uui-popover-container: set popover attribute automatically #664

Merged
merged 2 commits into from
Nov 22, 2023

Conversation

JesmoDev
Copy link
Contributor

@JesmoDev JesmoDev commented Nov 22, 2023

This PR makes sure that the popover container always has the popover attribute as it is needed by the native Popover API.
It checks if a popover value is already present (example popover='manual') to prevent unwanted overides.
Also updates the docs to reflect the changes

Now you can use the popover as such:

<uui-popover-container id="my-popover">
...content
</uui-popover-container>

instead of

<uui-popover-container id="my-popover" popover>
...content
</uui-popover-container>

Description

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-664.westeurope.azurestaticapps.net

Copy link

Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-664.westeurope.azurestaticapps.net

@iOvergaard iOvergaard added the enhancement New feature or request label Nov 22, 2023
@iOvergaard iOvergaard changed the title Popover-container: set popover attribute automaticly Popover-container: set popover attribute automatically Nov 22, 2023
@iOvergaard iOvergaard changed the title Popover-container: set popover attribute automatically uui-popover-container: set popover attribute automatically Nov 22, 2023
@iOvergaard iOvergaard merged commit 201f449 into v1/contrib Nov 22, 2023
9 of 10 checks passed
@iOvergaard iOvergaard deleted the feature/popover-container-default-value branch November 22, 2023 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants