-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Align uui-select with other inputs #658
Conversation
…element and add a variable to control it
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-658.westeurope.azurestaticapps.net |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
…because it is easiest to control the select rather than mimick it in terms of :focus and :hover on the outer element
@loivsen good catch. I moved the height to the inner element where the other properties are so they at least on paper have the same 33px default height. (If you inspect the elements, you can check it) The browser still places the elements a bit out of line, however if you add |
Azure Static Web Apps: Your stage site is ready! Visit it here: https://delightful-beach-055ecb503-658.westeurope.azurestaticapps.net |
Alternative would be to adjust the padding in the select element to have 2 pixels more in the top than in the bottom, but it's probably best if we avoid too much magic numbers. |
Description
Based on this comment we have moved a few fixes back to this library: umbraco/Umbraco-CMS#15037 (comment)
This aligns uui-select and uui-input with each other, so they work well together in a form having the same height and background-color properties.
We also now document the custom CSS properties in both elements and the story for a combined form has been fixed.
Types of changes