Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement eslint rules to move style prop in the bottom of the class #615

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

nielslyngsoe
Copy link
Member

@nielslyngsoe nielslyngsoe commented Oct 16, 2023

There are we few developers who got fond of the approach in New Backoffice, so I'm applying the eslint rule to move the style property in the bottom of the components. When we have styles next to rendering methods and are consistent with New Backoffice eslinting in the regard.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Consistency, I see developers who have started this movement already.

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes. (Well, the eslint rule it self is sort of a test)

@iOvergaard iOvergaard added internal Updates to dependencies, rewrite of files, cleanup, chores dependencies Pull requests that update a dependency file labels Oct 17, 2023
@iOvergaard iOvergaard merged commit fdb6c84 into v1/contrib Oct 17, 2023
8 of 9 checks passed
@iOvergaard iOvergaard deleted the v1/feature/local-rules-for-eslint branch October 17, 2023 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file internal Updates to dependencies, rewrite of files, cleanup, chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants