Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for GitHub Codespaces #609

Merged
merged 4 commits into from
Oct 17, 2023

Conversation

warrenbuckley
Copy link
Contributor

@warrenbuckley warrenbuckley commented Oct 10, 2023

Description

This adds support for GitHub Codespaces to ensure easier contributions to the project without having to worry about dependencies

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

This helps first time contributors and others to get straight into coding and not have to worry about dependencies, this also preconfigures VSCode with preferred extensions and settings to help with a nice DX

How to test?

  • Create a CodeSpace
    image

  • Inside VSCode open a terminal and switch to the branch for this PR

  • Use VSCode command palette CTRL + SHIFT + P and search for Codespaces: Full Rebuild Container
    image

  • npm install should have already run and the node_modules folder should be present already

  • The Code Spellchecker extension and the Prettier VSCode extension are installed

  • The port for Storybook is defined

image

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@warrenbuckley warrenbuckley marked this pull request as ready for review October 10, 2023 08:45
@warrenbuckley
Copy link
Contributor Author

@iOvergaard let me know what you think?

Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, thanks! #h5yr

@iOvergaard iOvergaard added internal Updates to dependencies, rewrite of files, cleanup, chores community/pr hacktoberfest/contrib-2023 labels Oct 17, 2023
@iOvergaard iOvergaard merged commit b440860 into umbraco:v1/contrib Oct 17, 2023
5 of 7 checks passed
@warrenbuckley warrenbuckley deleted the add-codespaces branch October 17, 2023 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr hacktoberfest/contrib-2023 internal Updates to dependencies, rewrite of files, cleanup, chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants