Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#599 Fix : Incorrect links from readme to components in Storybook #603

Merged
merged 2 commits into from
Oct 10, 2023

Conversation

LiliM4
Copy link
Contributor

@LiliM4 LiliM4 commented Oct 6, 2023

Description

Example: change of URL from 'https://uui.umbraco.com/?path=/story/uui-box' to 'https://uui.umbraco.com/?path=/docs/uui-box--docs' in the uui-box readme file

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Chore (minor updates related to the tooling or maintenance of the repository, does not impact compiled assets)

Motivation and context

Bug: #599

How to test?

Screenshots (if appropriate)

Checklist

  • If my change requires a change to the documentation, I have updated the documentation in this pull request.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.

@github-actions
Copy link

github-actions bot commented Oct 6, 2023

Hi there @LiliM4, thank you for this contribution! 👍

While we wait for the team to have a look at your work, we wanted to let you know about that we have a checklist for some of the things we will consider during review:

  • It's clear what problem this is solving, there's a connected issue or a description of what the changes do and how to test them
  • The automated tests all pass (see "Checks" tab on this PR)
  • The level of security for this contribution is the same or improved
  • The level of performance for this contribution is the same or improved
  • Avoids creating breaking changes; note that behavioral changes might also be perceived as breaking
  • If this is a new feature, Umbraco HQ provided guidance on the implementation beforehand
  • 💡 The contribution looks original and the contributor is presumably allowed to share it

Don't worry if you got something wrong. We like to think of a pull request as the start of a conversation, we're happy to provide guidance on improving your contribution.

If you realize that you might want to make some changes then you can do that by adding new commits to the branch you created for this work and pushing new commits. They should then automatically show up as updates to this pull request.

Thanks, from your friendly Umbraco GitHub bot 🤖 🙂

@LiliM4 LiliM4 changed the title #599 : Incorrect link from readme to component in Storybook #599 Fix : Incorrect link from readme to component in Storybook Oct 6, 2023
@bjarnef
Copy link
Contributor

bjarnef commented Oct 9, 2023

Hi @LiliM4

Great you had a look at this 🙌
Maybe you could also update this for the other components as well?

@LiliM4
Copy link
Contributor Author

LiliM4 commented Oct 9, 2023

Hi @LiliM4

Great you had a look at this 🙌 Maybe you could also update this for the other components as well?

Done :)

@LiliM4 LiliM4 changed the title #599 Fix : Incorrect link from readme to component in Storybook #599 Fix : Incorrect links from readme to components in Storybook Oct 9, 2023
@iOvergaard iOvergaard added documentation Improvements or additions to documentation community/pr hacktoberfest/contrib-2023 labels Oct 10, 2023
Copy link
Contributor

@iOvergaard iOvergaard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thank you so much for your contribution!

@iOvergaard iOvergaard merged commit 1a7ba8b into umbraco:v1/contrib Oct 10, 2023
6 of 7 checks passed
@iOvergaard iOvergaard linked an issue Oct 18, 2023 that may be closed by this pull request
@umbrabot
Copy link

Hi there @LiliM4!

First of all: A big #H5YR for making an Umbraco related contribution during Hacktoberfest! We are very thankful for the huge amount of PRs submitted, and all the amazing work you've been doing 🥇

Due to the amazing work you and others in the community have been doing, we've had a bit of a hard time keeping up. 😅 While all of the PRs for Hacktoberfest might not have been merged yet, you still qualify for receiving some Umbraco swag, congratulations! 🎉

In the spirit of Hacktoberfest we've prepared some exclusive Umbraco swag for all our contributors - including you!

As an alternative choice this year, you can opt-out of receiving anything and ask us to help improve the planet instead by planting a tree on your behalf. 🌳

Receive your swag or plant a tree! 👈 Please follow this link to fill out and submit the form, before December 15th, 2022, 23:59:00 UTC.

Following this date we'll be sending out all the swag, but please note that it might not reach your doorstep for a few months, so please bear with us and be patient 🙏

📢 We have just published a summary of all the activity throughout this year's Umbraco Hacktoberfest.

The only thing left to say is thank you so much for participating in Hacktoberfest! We really appreciate the help!

Kind regards,
The various Umbraco teams.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community/pr documentation Improvements or additions to documentation hacktoberfest/contrib-2023
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect link from readme to component in Storybook
4 participants