UUI-Box: Removing local definition of --uui-box-default-padding #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iOvergaard
approved these changes
Apr 1, 2022
iOvergaard
deleted the
bugfix/uui-box-revert-local---uui-box-default-padding
branch
iOvergaard
added a commit
that referenced
this pull request
Apr 1, 2022
* internal: added ignoreChanges to Lerna (#188) This helps us see which packages needs to be bumped when releasing * fix: add missing reference to uui-input-lock (#187) * fix: Remove local definition of --uui-box-default-padding for uui-box (#189) * remove local definition of --uui-box-default-padding * better description of slots * test --uui-box-default-padding can be defined outside scope BREAKING CHANGE: This should now be configured globally * internal: add more files to lerna ignore * Publish - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] - @umbraco-ui/[email protected] * update references * internal: use npm ci to counter Github Actions oddness * internal: try with unsafe-perm to counter differentiating OS'es * internal: downgrade Turbo to 1.1.5 to supposedly work with Github Actions Co-authored-by: Niels Lyngsø <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do not set the CSS custom property --uui-box-default-padding locally, as that prevents it begin set on a global level.
I as well added tests to prove that it is inherited from a parent.
Types of changes
Motivation and context
How to test?
Screenshots (if appropriate)
Checklist