Skip to content

Fix logic for retrieving lastKnownElement

CodeScene Delta Analysis / CodeScene Cloud Delta Analysis (v13/contrib) succeeded Apr 25, 2024 in 33s

CodeScene PR Check

✅ Code Health Quality Gates: OK

  • Improving Code Health: 2 findings(s) ✅

View detailed results in CodeScene

Details

✅ Improving Code Health:

  • Complex Method umbfocuslock.directive.js: FocusLock.link
  • Complex Conditional umbfocuslock.directive.js: FocusLock.link

Annotations

Check notice on line 111 in src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbfocuslock.directive.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/contrib)

✅ Getting better: Complex Method 

FocusLock.link decreases in cyclomatic complexity from 30 to 28, threshold = 9. This function has many conditional statements (e.g. if, for, while), leading to lower code health. Avoid adding more conditionals and code to it without refactoring.

Check notice on line 97 in src/Umbraco.Web.UI.Client/src/common/directives/components/forms/umbfocuslock.directive.js

See this annotation in the file changed.

@codescene-delta-analysis codescene-delta-analysis / CodeScene Cloud Delta Analysis (v13/contrib)

✅ No longer an issue: Complex Conditional 

FocusLock.link no longer has a complex conditional
View more details on CodeScene Delta Analysis