Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Granting access to the content dashboard for all user groups #9999

Merged
merged 8 commits into from
Mar 25, 2021

Conversation

elit0451
Copy link
Contributor

@elit0451 elit0451 commented Mar 17, 2021

Details

Adds the AllowContentDashboardAccessToAllUsers appSetting in the Web.config file, so the intro dashboard ("Getting Started") is shown to all user groups, not just admins. The change will affect all new projects. In the case that the config setting is not present the old access rules will apply, therefore not changing any existing behaviour.

Additionally, more information is reported from an existing dashboard - an admin parameter is added by the end.

Test

  • Remove the AllowContentDashboardAccessToAllUsers entry from the Web.config or change its value to false and verify that only users in the admin group have access to the Content dashboard;
  • Add it back or set it to true and create a few new users (ex: belonging to the Editors or Writers group) and check that the Content dashboard also appears (in addition to Redirect URL Management which was already there);

Note:
SensitiveData and Translators users have different UIs so the dashboard is not present at first glance, however, they have access to it!

@elit0451 elit0451 changed the title Granting access to the content dashboard to all user groups Granting access to the content dashboard for all user groups Mar 17, 2021
@nikolajlauridsen
Copy link
Contributor

Look good overall, I only have one concern that I've added as a comment, not sure what would be the best course of action though.

I see what you mean with SensitiveData and Translators not seeing the dashboard since it's only shown in the content section, but I agree that it's okay as it is regardless

@elit0451
Copy link
Contributor Author

Have done some refactoring 😉 maybe one of you @nikolajlauridsen or @bergmania can give it a second review 🙏

… to ContentDashboardSettings and saving AccessRulesFromConfig into a backing field
Copy link
Contributor

@nikolajlauridsen nikolajlauridsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍. Ran through the tests again and everything works splendidly 🎉

@nikolajlauridsen nikolajlauridsen merged commit 499e4f0 into v8/dev Mar 25, 2021
@nikolajlauridsen nikolajlauridsen deleted the v8/feature/AB10891-content-dashboard-config branch March 25, 2021 11:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants