Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#9964 Removed unneeded check for HttpContext #9978

Merged
merged 1 commit into from
Mar 18, 2021
Merged

#9964 Removed unneeded check for HttpContext #9978

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 2 additions & 3 deletions src/Umbraco.Core/IO/IOHelper.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,6 +81,7 @@ public static Attempt<string> TryResolveUrl(string virtualPath)
public static string MapPath(string path, bool useHttpContext)
{
if (path == null) throw new ArgumentNullException("path");

useHttpContext = useHttpContext && IsHosted;

// Check if the path is already mapped
Expand All @@ -89,10 +90,8 @@ public static string MapPath(string path, bool useHttpContext)
{
return path;
}
// Check that we even have an HttpContext! otherwise things will fail anyways
// http://umbraco.codeplex.com/workitem/30946

if (useHttpContext && HttpContext.Current != null)
if (useHttpContext)
{
//string retval;
if (String.IsNullOrEmpty(path) == false && (path.StartsWith("~") || path.StartsWith(SystemDirectories.Root)))
Expand Down