Fixes #9615 - Upgrade to Htmlsanitizer v5 #9856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nzdev
commented
Feb 20, 2021
| @@ -1293,7 +1296,7 @@ | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <!-- we want to exclude all facade references ?! --> | |||
| <FixedReferencePath Include="@(ReferencePath)" Condition="'%(ReferencePath.FileName)' != 'System.ValueTuple' and '%(ReferencePath.FileName)' != 'System.Net.Http'" /> | |||
| <FixedReferencePath Include="@(ReferencePath)" Condition="'%(ReferencePath.FileName)' != 'System.ValueTuple' and '%(ReferencePath.FileName)' != 'System.Net.Http' and '%(ReferencePath.FileName)' != 'System.Text.Encoding.CodePages'" /> | |||
There was a problem hiding this comment.
This was the build fix
There was a problem hiding this comment.
Interesting.. I am not sure what the problem we're trying to solve with FixedReferencePath is but.. if it works, it works 🤷
1 task
nul800sebastiaan
approved these changes
Feb 20, 2021
| @@ -1293,7 +1296,7 @@ | |||
| </PropertyGroup> | |||
| <ItemGroup> | |||
| <!-- we want to exclude all facade references ?! --> | |||
| <FixedReferencePath Include="@(ReferencePath)" Condition="'%(ReferencePath.FileName)' != 'System.ValueTuple' and '%(ReferencePath.FileName)' != 'System.Net.Http'" /> | |||
| <FixedReferencePath Include="@(ReferencePath)" Condition="'%(ReferencePath.FileName)' != 'System.ValueTuple' and '%(ReferencePath.FileName)' != 'System.Net.Http' and '%(ReferencePath.FileName)' != 'System.Text.Encoding.CodePages'" /> | |||
There was a problem hiding this comment.
Interesting.. I am not sure what the problem we're trying to solve with FixedReferencePath is but.. if it works, it works 🤷
nul800sebastiaan
changed the title
nul800sebastiaan
added
community/pr
dependencies
nul800sebastiaan
changed the title
nul800sebastiaan
pushed a commit
that referenced
this pull request
Feb 22, 2021
nul800sebastiaan
pushed a commit
that referenced
this pull request
Mar 9, 2021
nul800sebastiaan
added
status/dependency-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
If there's an existing issue for this PR then this fixes
Description
Restores HtmlSanitizer v5. Builds. Also some small optimisations for building the icon lists. IHtmlSanitizer injected via constructor and registered in a composer, allowing for customization.
Reverts
#9803 @nul800sebastiaan
Fixes #9615