Performance and accessibility improvements on the embed screen #9810
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge latest Umbraco v8 into my repo
…into v8/contrib # Please enter a commit message to explain why this merge is necessary, # especially if it merges an updated upstream into a topic branch. # # Lines starting with '#' will be ignored, and an empty message aborts # the commit.
… technology knows when a url retrieve has been succesfull. Added labels for the controls Preview reload only triggered if the values for height and width change
|
Good stuff, thanks very much @RachBreeze 👍 |
|
Sorry, I forgot to say this PR was the start of a series of PRs based on this issue #8704 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added aliases to control groups to help screen readers identify elements within the embed.
Also added support for retrieving the embed item only when the size changes. This improves both performances as the preview is only repopulated if the width/ height values change. It also aids accessibility as the reload of the preview is performed when a user tabs off the width/ height textboxes and the reloading of the preview causes the focus to be reset on the preview.
There is still an accessibility bug, when the width/ height is resized as focus is still reset on the to the preview. This is due to how the preview is being reloaded, the preview is hidden, removing the textboxes for height/ width meaning they don't exist in the screen to be focused on.